-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bytes: require 0.4.4 #350
bytes: require 0.4.4 #350
Conversation
Hrm. Seems |
This version is compatible with the minimal-versions flag.
a26f45a
to
f7dedf8
Compare
Requires a release of tokio-rs/bytes#312 |
I poked the bottom of this PR hole; hopefully it can cause some movement to let this get merged :) . |
looks like a conflict ::( |
Not surprising; I'll rebase once the dependent PRs are merged (and have a release on crates.io to depend on). |
Well, this might need to go to 0.1.x as well now because of that :) . |
Branch whack-a-mole! Seriously, thanks for trying to fix this. I hope there is a potential for an 0.1.21 with the fix, as I suspect some projects will need to support both http 0.1 and 0.2 for some transition period. |
I'll probably be back for 0.2 at some point. I've got a lot of plates in the air for my own set of crates at the moment before I can start to actually fix everything :) . |
Ping? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, just realized this requires bytes 0.4.13 but the latest is 12? Is there a reason for 13?
@mathstuf is this something we still want to go with or should we close this in favor of ensuring 0.5 has all the fixes we need? |
Oh, my bad. I thought this was the bottom of my stack. This will need the PR mentioned above first. Sorry for the noise. Going down one level deeper. |
If there is action on #440 this should probably just be closed as semi-duplicate. |
I'm more interested in |
this can be closed |
It looks like #440 also got closed. Would another minimal versions support PR make it any further? |
Yea, it'd be a good thing to add to CI. Sorry we missed these, but we have more attention now. |
Various APIs used in this crate were added in 0.4.4.